Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify --yjit-stats=quiet in YJIT CI #4010

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jethrodaniel
Copy link
Contributor

What does this PR do?

Adds a clarification comment.

See #3991 (comment)

@jethrodaniel jethrodaniel marked this pull request as ready for review October 17, 2024 16:33
@jethrodaniel jethrodaniel requested a review from a team as a code owner October 17, 2024 16:33
Copy link
Contributor

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @jethrodaniel

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (60febf8) to head (d403350).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4010      +/-   ##
==========================================
+ Coverage   97.87%   97.88%   +0.01%     
==========================================
  Files        1314     1314              
  Lines       78635    78635              
  Branches     3895     3895              
==========================================
+ Hits        76963    76972       +9     
+ Misses       1672     1663       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ivoanjo ivoanjo merged commit 167d8a5 into DataDog:master Oct 18, 2024
191 of 199 checks passed
@jethrodaniel jethrodaniel deleted the clarify-yjit-ci-stats branch October 18, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants