Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for sidekiq quantize #4025

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

estherk15
Copy link

@estherk15 estherk15 commented Oct 24, 2024

What does this PR do?

Add an example configuration for the Sidekiq quantize parameter

Motivation:

The ruby tracer had some updates from V1 to V2. In V1, there was an argument "tag_args" which performed this functionality (legacy pubdocs link), but it was depreciated in V2. In V2, the current pub documentation is sparse, but digging through the GIT PRs, it seems like the functionality was moved to the quantize argument: #3396. Could the V2 pubdocs be updated to reflect this change?

Change log entry

  • This updates the public docs

Additional Notes:

How to test the change?

@estherk15 estherk15 requested a review from a team as a code owner October 24, 2024 14:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (14cdd6f) to head (70b4003).

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #4025      +/-   ##
===========================================
- Coverage    97.86%   97.85%   -0.01%     
===========================================
  Files         1314     1314              
  Lines        78652    78652              
  Branches      3909     3909              
===========================================
- Hits         76973    76967       -6     
- Misses        1679     1685       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Oct 24, 2024

Benchmarks

Benchmark execution time: 2024-10-24 15:28:20

Comparing candidate commit 70b4003 in PR branch esther/update-ruby-sidekiq-quantize with baseline commit 14cdd6f in branch release.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.585op/s; -0.508op/s] or [-8.339%; -7.246%]

scenario:tracing - Propagation - Trace Context

  • 🟩 throughput [+4346.118op/s; +4465.396op/s] or [+12.629%; +12.976%]

@marcotc marcotc merged commit 7035870 into release Oct 24, 2024
242 of 243 checks passed
@marcotc marcotc deleted the esther/update-ruby-sidekiq-quantize branch October 24, 2024 16:00
@github-actions github-actions bot added this to the 2.5.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants