[NO-TICKET] Fix crashtracking sending parent pid/runtime-id when child crashes

[ivoanjo]

What does this PR do?

This PR fixes a bug in the crashtracking component: because it cached all of the tags from creation, if a process forked, it would use the tags from the parent, which included a (now-incorrect) pid and runtime-id.

Motivation:

This makes sure we have accurate metadata in crashtracking reports.

Change log entry

(Internal change, not relevant for changelog)

Additional Notes:

N/A

How to test the change?

I've added test coverage for this change. It can also be observed by using

$ DD_CRASHTRACKING_ENABLED=true bundle exec ruby -e 'require "datadog/auto_instrument"; puts "Parent: #{Process.pid} #{Datadog::Core::Environment::Identity.id}"; fork { puts "Child: #{Process.pid} #{Datadog::Core::Environment::Identity.id}"; Process.kill("SEGV", Process.pid) }'

and validating that the correct pid/runtime-id from the child is sent in the metadata.

[datadog-datadog-prod-us1]

⚪ Code Quality Violation

Suggested change

	expect(Datadog::Core::Crashtracking::TagBuilder).to receive(:call).with(:latest_settings).and_return([:latest_tags])
	expect(Datadog::Core::Crashtracking::TagBuilder).to receive(:call).with(:latest_settings).and_return(%i[latest_tags])

Consider using the %i syntax instead (...read more)

The rule "Prefer %i to the literal array syntax" is a guideline that encourages the use of the %i syntax for arrays of symbols. This is a part of the Ruby style guide that aims to promote conciseness and readability.

Symbols are immutable, reusable objects often used in Ruby instead of strings when the value does not need to be changed. When declaring an array of symbols, using the %i syntax can make your code cleaner and easier to read.

To adhere to this rule, instead of declaring an array of symbols using the literal array syntax like [:foo, :bar, :baz], use the %i syntax like %i[foo bar baz]. It's a good practice to consistently use %i for arrays of symbols as it enhances code readability and maintainability.

    

[datadog-datadog-prod-us1]

⚪ Code Quality Violation

Suggested change

	hash_including(tags_as_array: [:latest_tags])
	hash_including(tags_as_array: %i[latest_tags])

Consider using the %i syntax instead (...read more)

The rule "Prefer %i to the literal array syntax" is a guideline that encourages the use of the %i syntax for arrays of symbols. This is a part of the Ruby style guide that aims to promote conciseness and readability.

Symbols are immutable, reusable objects often used in Ruby instead of strings when the value does not need to be changed. When declaring an array of symbols, using the %i syntax can make your code cleaner and easier to read.

To adhere to this rule, instead of declaring an array of symbols using the literal array syntax like [:foo, :bar, :baz], use the %i syntax like %i[foo bar baz]. It's a good practice to consistently use %i for arrays of symbols as it enhances code readability and maintainability.

    

[Strech]

LGTM 💯

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-10-25 13:35:08

Comparing candidate commit 06dfc27 in PR branch ivoanjo/fix-crashtracking-pid-runtimeid-on-fork with baseline commit 91d883f in branch master.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 21 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

• 🟩 throughput [+0.471op/s; +0.524op/s] or [+7.401%; +8.236%]

scenario:tracing - Propagation - Datadog

• 🟥 throughput [-3440.700op/s; -3340.000op/s] or [-10.231%; -9.932%]

scenario:tracing - Propagation - Trace Context

• 🟩 throughput [+3555.631op/s; +3676.609op/s] or [+10.294%; +10.644%]

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (91d883f) to head (06dfc27).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4031      +/-   ##
==========================================
- Coverage   97.86%   97.86%   -0.01%     
==========================================
  Files        1321     1321              
  Lines       79326    79329       +3     
  Branches     3934     3934              
==========================================
+ Hits        77631    77632       +1     
- Misses       1695     1697       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.