Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libdatadog musl from artifacts #4044

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Oct 29, 2024

What does this PR do?

This PR reduces the artifacts size by removing musl code from libdatadog gems

Comparison to previous PR: #4043

base(c803ac20fe15014e56585e7d0119e9a07535f8bf) branch (064cdb5561946cc2faeb2b3791f8f0220cb6f896)
173.7 mb 130.1 mb

Comment on lines +128 to +129
libdatadog_musl = versioned_path +
"gems" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

Consider using string interpolation or formatting instead of concatenation. (...read more)

The rule "Avoid string concatenation" is an important coding practice in Ruby for ensuring efficient and clean code. String concatenation in Ruby using the '+' operator creates a new string object, which can lead to excessive memory usage and slower performance when dealing with large strings or performing the operation multiple times.

Instead, Ruby provides alternatives that are more efficient. The string interpolation syntax #{} allows you to insert variables directly into strings without creating new string objects. This is not only more memory efficient, but also provides cleaner and more readable code.

Another alternative is the format method, which allows you to create a formatted string with placeholders for variables. This method is particularly useful when dealing with more complex strings, as it provides a clear and concise way to format your strings.

By following this rule, you can write more efficient and cleaner Ruby code, leading to better performance and readability.

View in Datadog  Leave us feedback  Documentation

@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label Oct 29, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review October 29, 2024 00:19
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner October 29, 2024 00:19
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Base automatically changed from tonycthsu/ssi-remove-ffi-ext to master October 29, 2024 10:33
@TonyCTHsu TonyCTHsu merged commit e4a0029 into master Oct 29, 2024
265 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/ssi-remove-libdatadog-musl branch October 29, 2024 10:56
@github-actions github-actions bot added this to the 2.5.0 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants