Fix Intel case #4051
Merged
Fix Intel case #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloeki
force-pushed
the
lloeki/x64-not-x86
branch
2 times, most recently
from
9556f8f
to
ab0c7de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4051 +/- ##
==========================================
+ Coverage 97.71% 97.73% +0.01%
==========================================
Files 1338 1338
Lines 80248 80248
Branches 4016 4016
==========================================
+ Hits 78418 78433 +15
+ Misses 1830 1815 -15 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
approved these changes
Oct 31, 2024
TonyCTHsu
added
the
dev/internal
lloeki
force-pushed
the
lloeki/x64-not-x86
branch
from
ab0c7de
to
34b9e67
Compare
- x86_64 glibc is supported - 32bit (x86 or armv7hf) glibc is not - musl is not (yet), for all cpu archs Add better negative tests to cover those base cases.
TonyCTHsu
force-pushed
the
lloeki/x64-not-x86
branch
from
3e252a5
to
da7fc67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Swap
x86brain fart forx64. Indeed:Add better negative tests to cover those base cases.
Motivation:
Wetware failure.
Change log entry
Additional Notes:
The world is imperfect and we can't have nice things (like unambiguous gcc/clang triplets).
JIRA
How to test the change?
CI (
dd-gitlab/requirements_json_test)