Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove edge build #4056

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Remove edge build #4056

merged 1 commit into from
Nov 5, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 1, 2024

What does this PR do?

This workflow has not been providing value and not quite actionable. And it took 25% of our credits usage.

Currently, we have setup automatation to update matrix, which supersedes the edge build.

@TonyCTHsu TonyCTHsu added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Nov 1, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 1, 2024

Benchmarks

Benchmark execution time: 2024-11-05 18:09:36

Comparing candidate commit 097df98 in PR branch tonycthsu/remove-edge with baseline commit a122d5d in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:tracing - Tracing.log_correlation

  • 🟥 throughput [-6982.558op/s; -6574.753op/s] or [-5.876%; -5.533%]

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (a122d5d) to head (097df98).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4056   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files        1338     1338           
  Lines       80248    80248           
  Branches     4016     4016           
=======================================
+ Hits        78420    78423    +3     
+ Misses       1828     1825    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu added this to the 2.6.0 milestone Nov 5, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review November 5, 2024 15:10
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 5, 2024 15:10
@TonyCTHsu TonyCTHsu merged commit dedb0bb into master Nov 5, 2024
268 of 269 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-edge branch November 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants