fix rack 3/rackup situation on ruby 3.4 #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-datadog
added
the
dev/internal
|
The ruby 3.3 failure is being repaired as part of 2.5.0 release process, after 2.5.0 goes out merging master into this PR should make that configuration green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4068 +/- ##
=======================================
Coverage 97.72% 97.73%
=======================================
Files 1338 1338
Lines 80248 80248
Branches 4016 4016
=======================================
+ Hits 78424 78427 +3
+ Misses 1824 1821 -3 ☔ View full report in Codecov by Sentry. |
sarahchen6
approved these changes
Nov 5, 2024
marcotc
approved these changes
Nov 5, 2024
rack 3.1.0 deletes Rack::VERSION constant (in rack/rack#1966), causing our tests to fail. Use Rack::RELEASE instead of Rack::VERSION to work around the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
rack 3.1.0 deletes Rack::VERSION constant (in
rack/rack#1966),
causing our tests to fail.
Use Rack::RELEASE instead of Rack::VERSION
to work around the issue
Motivation:
Repairing CI in #4040
Change log entry
None, changes are in test suite only.
Additional Notes:
How to test the change?
I am assuming currently the tests lock rack to pre-3.1.0 therefore there aren't any failures on master, however #4059 exposed this failure when trying to get a new ruby 3.4 configuration going in circleci.