Use BUNDLE_GEMFILE directly instead of appraisal binary #4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appraisal binary appears to be incompatible with bundler 2.4+ that set BUNDLER_SETUP environment variable. In some cases developers are already using BUNDLE_GEMFILE manually to invoke appraisal configurations, probably those using ruby 3.3 and newer. This commit changes the rakefile to always use BUNDLE_GEMFILE approach, making it work for all Ruby versions, and adds documentation stating that appraisal binary does not work and to use the BUNDLE_GEMFILE manual approach.
p-datadog
changed the title
|
This PR should repair the need to pin to old versions of bundler as was done in #4054. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4069 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 1338 1338
Lines 80248 80248
Branches 4016 4016
=======================================
Hits 78422 78422
Misses 1826 1826 ☔ View full report in Codecov by Sentry. |
p-datadog
added
the
dev/internal
TonyCTHsu
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
appraisal binary appears to be incompatible with bundler 2.4+ that set BUNDLER_SETUP environment variable.
In some cases developers are already using BUNDLE_GEMFILE manually to invoke appraisal configurations, probably those using ruby 3.3 and newer.
This PR changes the rakefile to always use BUNDLE_GEMFILE approach, making it work for all Ruby versions, and adds documentation stating that appraisal binary does not work and to use the BUNDLE_GEMFILE manual approach.
Motivation:
Fixing CI in #4040
Change log entry
None
Additional Notes:
How to test the change?
Tested in #4059