-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Lint job from CircleCI to Github Action #4071
Conversation
BenchmarksBenchmark execution time: 2024-11-05 16:28:07 Comparing candidate commit d2b474f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4071 +/- ##
==========================================
- Coverage 97.73% 97.72% -0.02%
==========================================
Files 1338 1338
Lines 80248 80248
Branches 4016 4016
==========================================
- Hits 78432 78422 -10
- Misses 1816 1826 +10 ☔ View full report in Codecov by Sentry. |
- uses: actions/checkout@v4 | ||
- name: Install dependencies | ||
run: bundle install | ||
- run: bundle exec rake rubocop standard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be clearer (for the person reading failures) to have rubocop and standard invoked separately.
/gitlab resync-job-status |
🚨 Devflow GET https://gitlab.ddbuild.io/api/v4/projects/305/pipelines/48269606/jobs: 404 {message: 404 Not found} Details
If you need support, contact us on slack #ci-infra-support with those details! |
What does this PR do?
Migrating CircleCI lint job to Github Actions