Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Lint job from CircleCI to Github Action #4071

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 5, 2024

What does this PR do?

Migrating CircleCI lint job to Github Actions

@TonyCTHsu TonyCTHsu marked this pull request as ready for review November 5, 2024 15:56
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 5, 2024 15:56
@pr-commenter
Copy link

pr-commenter bot commented Nov 5, 2024

Benchmarks

Benchmark execution time: 2024-11-05 16:28:07

Comparing candidate commit d2b474f in PR branch tonycthsu/migrate-lint-job with baseline commit 243ed25 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (243ed25) to head (d2b474f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4071      +/-   ##
==========================================
- Coverage   97.73%   97.72%   -0.02%     
==========================================
  Files        1338     1338              
  Lines       80248    80248              
  Branches     4016     4016              
==========================================
- Hits        78432    78422      -10     
- Misses       1816     1826      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- uses: actions/checkout@v4
- name: Install dependencies
run: bundle install
- run: bundle exec rake rubocop standard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be clearer (for the person reading failures) to have rubocop and standard invoked separately.

@TonyCTHsu
Copy link
Contributor Author

/gitlab resync-job-status

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚨 Devflow

GET https://gitlab.ddbuild.io/api/v4/projects/305/pipelines/48269606/jobs: 404 {message: 404 Not found}

Details
child workflow execution error (type: cirel.Cirel_SyncCommitJobsStatusWorkflow, workflowID: c66fc030-293d-480f-a891-153208a68715_32, runID: 61fdb2e8-2660-4fde-afba-d709e10f1a91, initiatedEventID: 32, startedEventID: 33): activity error (type: gitlab.GitlabService_GetJobsByCommit, scheduledEventID: 14, startedEventID: 15, identity: 1@gitlab-worker-74cf665c5-zgwzh@): GET https://gitlab.ddbuild.io/api/v4/projects/305/pipelines/48269606/jobs: 404 {message: 404 Not found} (type: ErrorResponse, retryable: true)

If you need support, contact us on slack #ci-infra-support with those details!

@TonyCTHsu TonyCTHsu added dev/tooling Involves tools (e.g. Rubocop, CodeCov) dev/github Github repository maintenance and automation labels Nov 5, 2024
@TonyCTHsu TonyCTHsu merged commit a122d5d into master Nov 5, 2024
272 of 273 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/migrate-lint-job branch November 5, 2024 17:24
@github-actions github-actions bot added this to the 2.6.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants