Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Remove unused rspec integration app #4081

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Nov 7, 2024

What does this PR do?
Removes unused RSpec integration app

Motivation:
This code never runs, datadog-ci integration was extracted to a separate gem

How to test the change?
Safe to merge if pipelines will eventually become green

@anmarchenko anmarchenko requested a review from a team as a code owner November 7, 2024 08:48
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Nov 7, 2024
@anmarchenko anmarchenko added the dev/internal Other internal work that does not need to be included in the changelog label Nov 7, 2024
@TonyCTHsu TonyCTHsu merged commit 19b7b02 into master Nov 7, 2024
264 of 266 checks passed
@TonyCTHsu TonyCTHsu deleted the anmarchenko/remove_rspec_integration_test branch November 7, 2024 09:02
@github-actions github-actions bot added this to the 2.7.0 milestone Nov 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (33f30f7) to head (455f7a5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4081      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files        1338     1338              
  Lines       80251    80251              
  Branches     4017     4017              
==========================================
- Hits        78425    78424       -1     
- Misses       1826     1827       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants