[NO-TICKET] Re-enable ASAN memory leaks testing #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR re-enables the memory leak testing using the asan tool job in CI. For context, we added this testing in #3864 (more details about what asan is can be found in that PR), but had to disable it in #3915 as the upstream Ruby builds we were using were broken and unavailable for a while. This has since been fixed upstream, and so let's re-enable this CI job. In fact, upstream now officially allows these builds to be used, so we no longer even need our fork of `setup-ruby` to enable them. **Motivation:** Improve our testing for native memory leaks. **Additional Notes:** N/A **How to test the change?** Validate that the "test-asan" is now running in CI.
ivoanjo
added
dev/testing
github-actions
bot
added
the
dev/github
AlexJF
approved these changes
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4086 +/- ##
==========================================
+ Coverage 97.72% 97.73% +0.01%
==========================================
Files 1338 1338
Lines 80251 80259 +8
Branches 4017 4017
==========================================
+ Hits 78428 78445 +17
+ Misses 1823 1814 -9 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-11-07 16:21:44 Comparing candidate commit f1cd362 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR re-enables the memory leak testing using the asan tool job in CI.
For context, we added this testing in #3864 (more details about what asan is can be found in that PR), but had to disable it in #3915 as the upstream Ruby builds we were using were broken and unavailable for a while.
This has since been fixed upstream, and so let's re-enable this CI job.
In fact, upstream now officially allows these builds to be used, so we no longer even need our fork of
setup-rubyto enable them.Motivation:
Improve our testing for native memory leaks.
Change log entry
(Not relevant, testing-only)
Additional Notes:
N/A
How to test the change?
Validate that the "test-asan" is now running in CI. Here's a successful run on "test-asan" in CI with this branch: https://github.com/DataDog/dd-trace-rb/actions/runs/11726300446/job/32664597998 .