Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile for Ruby 3.4 #4095

Closed
wants to merge 3 commits into from

Conversation

sarahchen6
Copy link
Contributor

What does this PR do?
This PR updates the Gemfile to support Ruby 3.4

Motivation:
Ruby 3.4 no longer includes a few necessary default gems (see here). The newest version of the webrick gem has been released, and the strscan gem version that supports Ruby 3.4 has not been released. This PR addresses these points.

Change log entry
No change log necessary.

Additional Notes:

How to test the change?
Green CI.

@pr-commenter
Copy link

pr-commenter bot commented Nov 8, 2024

Benchmarks

Benchmark execution time: 2024-11-13 16:37:19

Comparing candidate commit 6dcd5cd in PR branch sarahchen6/update-gemfile-for-3.4 with baseline commit 494abac in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

Gemfile Show resolved Hide resolved
@sarahchen6 sarahchen6 force-pushed the sarahchen6/update-gemfile-for-3.4 branch 2 times, most recently from 2dcdb08 to 3b585d7 Compare November 12, 2024 18:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (494abac) to head (6dcd5cd).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4095      +/-   ##
==========================================
+ Coverage   97.76%   97.78%   +0.01%     
==========================================
  Files        1350     1350              
  Lines       81062    81062              
  Branches     4085     4085              
==========================================
+ Hits        79254    79266      +12     
+ Misses       1808     1796      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarahchen6 sarahchen6 marked this pull request as ready for review November 12, 2024 20:58
@sarahchen6 sarahchen6 requested a review from a team as a code owner November 12, 2024 20:58
@sarahchen6 sarahchen6 force-pushed the sarahchen6/update-gemfile-for-3.4 branch from 269a9dc to af700d0 Compare November 13, 2024 15:43
@sarahchen6
Copy link
Contributor Author

This PR' changes (along with #4111 ) have been combined in #4114.

@sarahchen6 sarahchen6 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants