-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-2334 dynamic instrumentation probe manager + instrumentation integration tests #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/datadog/di/contrib/active_record/serializer_active_record_spec.rb
Outdated
Show resolved
Hide resolved
p-datadog
force-pushed
the
di-instrumentation
branch
from
November 11, 2024 16:03
529f20e
to
33678ae
Compare
p-datadog
force-pushed
the
di-instrumentation
branch
from
November 12, 2024 15:45
f422970
to
a521628
Compare
p-datadog
force-pushed
the
di-instrumentation
branch
from
November 12, 2024 16:04
8aa405a
to
2386443
Compare
TonyCTHsu
approved these changes
Nov 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4097 +/- ##
==========================================
+ Coverage 97.74% 97.77% +0.02%
==========================================
Files 1341 1350 +9
Lines 80356 81052 +696
Branches 4030 4081 +51
==========================================
+ Hits 78541 79245 +704
+ Misses 1815 1807 -8 ☔ View full report in Codecov by Sentry. |
p-datadog
added
the
dev/internal
Other internal work that does not need to be included in the changelog
label
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation:
Initial DI implementation
Change log entry
None
Additional Notes:
This PR is extracted from #4063. It still does not enable DI for customers.
This PR is on top of #4088 and #4089, those PRs need to be merged first and then I will rebase this PR on master.
sig files are all stubs, I can edit them after all of the DI is in master but doing so currently causes churn that is not helping release DI on time.
How to test the change?
Unit and integration tests included.