Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin uri 0.13.1 for test #4099

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Pin uri 0.13.1 for test #4099

merged 3 commits into from
Nov 11, 2024

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Pin uri at 0.13.1 for test

Motivation:

The tests are failing because uri gem become its own gem and required by older rubygem version

@TonyCTHsu TonyCTHsu marked this pull request as ready for review November 11, 2024 13:35
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 11, 2024 13:35
@TonyCTHsu TonyCTHsu added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Nov 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (c8bd1e4) to head (3fb1b31).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4099      +/-   ##
==========================================
- Coverage   97.74%   97.72%   -0.02%     
==========================================
  Files        1338     1338              
  Lines       80264    80264              
  Branches     4017     4017              
==========================================
- Hits        78451    78442       -9     
- Misses       1813     1822       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2024

Benchmarks

Benchmark execution time: 2024-11-11 13:51:48

Comparing candidate commit 3fb1b31 in PR branch tonycthsu/url-rollback with baseline commit c8bd1e4 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu merged commit 347bc45 into master Nov 11, 2024
266 of 267 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/url-rollback branch November 11, 2024 13:56
@github-actions github-actions bot added this to the 2.7.0 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants