Deny rubygems-update injection
#4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
reviewed
Nov 13, 2024
andrewlock
reviewed
Nov 13, 2024
lloeki
force-pushed
the
lloeki/deny-rubygems-update-injection
branch
from
61a0bc7
to
bacd3fe
Compare
`rubygems-update` `setup.rb` re-execs itself when `RUBYOPT` is detected, which causes endless looping because injection adds it back immediately. See: https://github.com/rubygems/rubygems/blob/90c90addee4bda3130cf44f1321eebf162367d1b/setup.rb#L13-L20 Coverage is twofold: - Deny on `--disable-gems`: gems are required for ruby injector - Deny on `setup.rb`: This may be wide-catching but we don't want to instrument any of them anyway.
lloeki
force-pushed
the
lloeki/deny-rubygems-update-injection
branch
from
bacd3fe
to
20f2fa5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4108 +/- ##
==========================================
- Coverage 97.77% 97.77% -0.01%
==========================================
Files 1350 1350
Lines 81062 81062
Branches 4085 4085
==========================================
- Hits 79259 79256 -3
- Misses 1803 1806 +3 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-11-13 12:52:22 Comparing candidate commit 20f2fa5 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:method instrumentation
|
pawelchcki
approved these changes
Nov 13, 2024
brettlangdon
approved these changes
Nov 13, 2024
TonyCTHsu
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Coverage is twofold:
--disable-gems: gems are required for ruby injectorsetup.rb: This may be wide-catching but we don't want to instrument any of them anyway.Motivation:
rubygems-updatesetup.rbre-execs itself whenRUBYOPTis detected, which causes endless looping because injection adds it back immediately.See: https://github.com/rubygems/rubygems/blob/90c90addee4bda3130cf44f1321eebf162367d1b/setup.rb#L13-L20
Change log entry
Additional Notes:
JIRA
How to test the change?