Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter with splitted gemfile and task #4118

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 15, 2024

What does this PR do?

We've update our flow for dependency management in #4112, we should update the dependency filter to better allow our automated detection for updating lock files.

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 15, 2024 12:50
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Nov 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (ce1a178) to head (434b91c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4118   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1350     1350           
  Lines       81077    81150   +73     
  Branches     4085     4087    +2     
=======================================
+ Hits        79275    79347   +72     
- Misses       1802     1803    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks

Benchmark execution time: 2024-11-15 13:29:41

Comparing candidate commit 434b91c in PR branch tonycthsu/expand-deps-filter with baseline commit 6f4db56 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Trace Context

  • 🟥 throughput [-4189.478op/s; -4070.405op/s] or [-10.801%; -10.494%]

@TonyCTHsu TonyCTHsu merged commit d39fe33 into master Nov 15, 2024
266 of 267 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/expand-deps-filter branch November 15, 2024 14:02
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants