Skip to content

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Sep 24, 2025

What does this PR do?

Reports expression evaluation errors in the payload when building the message from template segments

Motivation:
Implementation of expression language for DI

Change log entry
Yes: dynamic instrumentation: report evaluation errors to the UI

Additional Notes:

How to test the change?

Tests are included

@p-datadog p-datadog requested a review from a team as a code owner September 24, 2025 17:28
@datadog-datadog-prod-us1
Copy link
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 90.91%
Total Coverage: 95.19% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 96c9fb1 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2025

Benchmarks

Benchmark execution time: 2025-09-24 17:51:42

Comparing candidate commit 96c9fb1 in PR branch di-eval-errors with baseline commit 9b2f922 in branch master.

Found 6 performance improvements and 0 performance regressions! Performance is the same for 38 metrics, 2 unstable metrics.

scenario:profiling - intern_all 1000 repeated strings

  • 🟩 throughput [+1398.081op/s; +1462.128op/s] or [+6.155%; +6.437%]

scenario:tracing - 1 span trace - no writer

  • 🟩 throughput [+614.719op/s; +657.919op/s] or [+5.210%; +5.576%]

scenario:tracing - 10 span trace - no writer

  • 🟩 throughput [+142.975op/s; +149.961op/s] or [+5.650%; +5.926%]

scenario:tracing - 100 span trace - no writer

  • 🟩 throughput [+19.986op/s; +20.734op/s] or [+6.638%; +6.887%]

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+3707.046op/s; +3788.827op/s] or [+12.791%; +13.073%]

scenario:tracing - Tracing.log_correlation

  • 🟩 throughput [+11310.964op/s; +11629.491op/s] or [+11.226%; +11.542%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants