-
Couldn't load subscription status.
- Fork 1.2k
Cloud Run Jobs Docs #32373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cloud Run Jobs Docs #32373
Conversation
| [3]: /tracing/other_telemetry/connect_logs_and_traces/dotnet/ | ||
| [4]: /developers/dogstatsd/?tab=dotnet#install-the-dogstatsd-client | ||
| [5]: /metrics/custom_metrics/dogstatsd_metrics_submission/?tab=dotnet#code-examples | ||
| [5]: /metrics/custom_metrics/dogstatsd_metrics_submission/?tab=dotnet#code-examples-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why use the distribution metric example instead of count?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only distribution metrics are supported in Serverless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason has to do with the lack of hostname, resulting in the backend thinking that unique metrics are actually duplicate retries of the same metric, resulting in lost & inaccurate metrics
| Because GitHub requests are rate limited, you must pass a GitHub token saved in the environment variable `GITHUB_TOKEN` as a [Docker build secret][1] `--secret id=github-token,env=GITHUB_TOKEN`. | ||
|
|
||
| {{< tabs >}} | ||
| {{% tab "Linux/AMD64" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make these titles clearer: the distinction is between glibc and musl -- alpine can very much be linux amd64
if you want something cleaner for users, you could differentiate them as Manylinux (glibc) and Alpine (musl)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Additional notes