Skip to content

Conversation

@nhulston
Copy link
Contributor

What does this PR do? What is the motivation?

  • Add docs for Cloud Run Jobs
  • Ruby & PHP are typically used for web apps (not Cloud Run Jobs), so I did not include them. We can always add them if requested by customers
  • Note that the sample apps links don't work right now (because Cloud Run Jobs Sample Apps serverless-gcp-sample-apps#82 has not merged yet). I will make sure Cloud Run Jobs Sample Apps serverless-gcp-sample-apps#82 is merged before merging this PR. I just want to start the review process for this PR now
  • We intentionally do not include Cloud Run Jobs in the sidecar yet, because we are in preview mode. That way, we can still send these docs directly to customers that are participating in the preview without exposing it to all customers.

Merge instructions

Merge readiness:

  • Ready for merge

Additional notes

@nhulston nhulston requested review from a team as code owners October 24, 2025 14:35
@nhulston nhulston added Do Not Merge Just do not merge this PR :) serverless labels Oct 24, 2025
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Oct 24, 2025
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@cswatt cswatt self-assigned this Oct 27, 2025
[3]: /tracing/other_telemetry/connect_logs_and_traces/dotnet/
[4]: /developers/dogstatsd/?tab=dotnet#install-the-dogstatsd-client
[5]: /metrics/custom_metrics/dogstatsd_metrics_submission/?tab=dotnet#code-examples
[5]: /metrics/custom_metrics/dogstatsd_metrics_submission/?tab=dotnet#code-examples-5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use the distribution metric example instead of count?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only distribution metrics are supported in Serverless

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason has to do with the lack of hostname, resulting in the backend thinking that unique metrics are actually duplicate retries of the same metric, resulting in lost & inaccurate metrics

Because GitHub requests are rate limited, you must pass a GitHub token saved in the environment variable `GITHUB_TOKEN` as a [Docker build secret][1] `--secret id=github-token,env=GITHUB_TOKEN`.

{{< tabs >}}
{{% tab "Linux/AMD64" %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make these titles clearer: the distinction is between glibc and musl -- alpine can very much be linux amd64

if you want something cleaner for users, you could differentiate them as Manylinux (glibc) and Alpine (musl)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion

@nhulston nhulston requested a review from ava-silver October 28, 2025 17:38
Copy link
Contributor

@ava-silver ava-silver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend Do Not Merge Just do not merge this PR :) serverless

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants