-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Migrating to the New Security Findings Data Model Guide
#33083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Migrating to the New Security Findings Data Model Guide
#33083
Conversation
Preview links (active after the
|
Migrating to the New Security Findings Data Model Guide
janine-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Daniel, thank you for putting together this PR and being willing to be the point of contact on your team! I made some general content suggestions, but know that this is going to be subject to change as the plan firms up. Let me know how I can help as it does! For now, I'll apply the WIP label on this while we wait for links and dates to go in the placeholders.
| @@ -0,0 +1,117 @@ | |||
| --- | |||
| title: Migrating to the New Security Findings Data Model | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| title: Migrating to the New Security Findings Data Model | |
| title: Migrate to the New Security Findings Data Model |
Small style thing! We tend to go for imperative verbs instead of gerunds 🤓 Just for brevity and a little extra directness.
|
|
||
| ## Overview | ||
|
|
||
| The way Security Findings are queried is changing and it may impact your workflows. You notice changes to how queries are constructed in Datadog. A set of [new features](#new-features) exposing that new schema is also released as a part of the upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The way Security Findings are queried is changing and it may impact your workflows. You notice changes to how queries are constructed in Datadog. A set of [new features](#new-features) exposing that new schema is also released as a part of the upgrade. | |
| The syntax for creating queries to search for Security Findings in Datadog is changing. While this change comes with a set of [new features](#new-features) exposing that new schema, it may also impact your existing workflows. | |
| This change affects all interfaces where you can query security findings data: | |
| - Explorers, dashboards, notification rules, and automation pipelines | |
| - Workflow Automation | |
| - API and Terraform resources |
|
|
||
| ## Required action | ||
|
|
||
| If you are using {insert relevant APIs / Terraform resource}, plan to migrate to the new version by {deprecation date}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If you are using {insert relevant APIs / Terraform resource}, plan to migrate to the new version by {deprecation date}. | |
| If you are using {insert relevant APIs / Terraform resource}, plan to migrate to the new version by {deprecation date} so you can avoid interruptions in your existing workflows. |
|
|
||
| If you are using {insert relevant APIs / Terraform resource}, plan to migrate to the new version by {deprecation date}. | ||
|
|
||
| Configuration in Datadog is updated automatically, so no action is needed there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we provide some detail on what "configuration in Datadog" means? How could a user determine what they need to change and what they can leave to us?
| ## What are Security Findings | ||
|
|
||
| Security Findings encompass vulnerabilities, misconfigurations, and security risks identified across your infrastructure and applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## What are Security Findings | |
| Security Findings encompass vulnerabilities, misconfigurations, and security risks identified across your infrastructure and applications. | |
| ## Security findings | |
| Security findings encompass vulnerabilities, misconfigurations, and security risks identified across your infrastructure and applications. |
|
|
||
| - A new unified findings public API | ||
| - Dashboard support for Code Security | ||
| - Graphing Security Findings in Datadog Sheets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Graphing Security Findings in Datadog Sheets | |
| - Graphing security findings in Datadog Sheets |
| - Dashboard support for Code Security | ||
| - Graphing Security Findings in Datadog Sheets | ||
| - Datadog Workflow Automation support for all finding types | ||
| - Using SQL to query Security Findings and join them with other Datadog Telemetry via DDSQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Using SQL to query Security Findings and join them with other Datadog Telemetry via DDSQL | |
| - Using SQL to query security findings and join them with other Datadog telemetry using DDSQL |
| ## How to prepare | ||
|
|
||
| - Every in-app feature will be automatically migrated. | ||
| - Legacy API endpoints and Terraform resources will eventually be deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heading and the content here don't really seem to match, because the heading would make me expect instructions about how to prepare, but then the bullets aren't action items. Can we rename the section or work the bullet points into the rest of the content on the page?
| | Before | After | | ||
| |--------|-------| | ||
| | **Misconfigurations:** `@workflow.triage.status:open status:critical`<br>**Library vulnerabilities:** `status:open severity:Critical` | **All findings:** `@status:open @severity:critical` | | ||
| | **Misconfigurations:** `@dd_computed_attributes.is_publicly_accessible:true`<br>**Host Vulnerabilities:** `is_publicly_accessible:Accessible` | **All findings:** `@risk.is_publicly_accessible:true` | | ||
| | **Library Vulnerabilities:** `library_name:org.apache.logging.log4j`<br>**Host Vulnerabilities:** `package:org.apache.logging.log4j` | **All findings:** `@package.name:org.apache.logging.log4j` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | Before | After | | |
| |--------|-------| | |
| | **Misconfigurations:** `@workflow.triage.status:open status:critical`<br>**Library vulnerabilities:** `status:open severity:Critical` | **All findings:** `@status:open @severity:critical` | | |
| | **Misconfigurations:** `@dd_computed_attributes.is_publicly_accessible:true`<br>**Host Vulnerabilities:** `is_publicly_accessible:Accessible` | **All findings:** `@risk.is_publicly_accessible:true` | | |
| | **Library Vulnerabilities:** `library_name:org.apache.logging.log4j`<br>**Host Vulnerabilities:** `package:org.apache.logging.log4j` | **All findings:** `@package.name:org.apache.logging.log4j` | | |
| | Before | After (all findings) | | |
| |--------|----------------------| | |
| | **Misconfigurations:** `@workflow.triage.status:open status:critical`<br>**Library vulnerabilities:** `status:open severity:Critical` | `@status:open @severity:critical` | | |
| | **Misconfigurations:** `@dd_computed_attributes.is_publicly_accessible:true`<br>**Host Vulnerabilities:** `is_publicly_accessible:Accessible` | `@risk.is_publicly_accessible:true` | | |
| | **Library Vulnerabilities:** `library_name:org.apache.logging.log4j`<br>**Host Vulnerabilities:** `package:org.apache.logging.log4j` | `@package.name:org.apache.logging.log4j` | |
Thought we could put "all findings" into the column header so we didn't have to repeat it 🙂
| ### Milestone 1: January 2026 | ||
|
|
||
| **Migrated Findings** (use new schema): | ||
| - Misconfigurations | ||
| - Identity Risks | ||
| - Attack Paths | ||
| - IaC & API Security Findings | ||
|
|
||
| **Platform Updates:** | ||
| - Dashboards | ||
| - DDSQL | ||
| - Sheets | ||
| - Findings Public API | ||
|
|
||
| ### Milestone 2: April 2026 | ||
|
|
||
| **Remaining Findings** (use new schema): | ||
| - Cloud Security Vulnerabilities | ||
| - Code Security Findings (SCA, SAST, IAST, Secrets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would rather keep this out of the external docs so we can keep some wiggle room in case we wind up diverging from this timeline. Above, we already do a good job of describing what changes are coming, and I think that's sufficient.
What does this PR do? What is the motivation?
We need a document describing the findings v2 schema migration. See here.