feat: add items iterator #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| if not overwrite: | ||
| overlap = set(cls.__dict__.keys()) & set(to_include.keys()) | ||
| if overlap: | ||
| raise ValueError("Configuration clashes detected: {}".format(overlap)) | ||
|
|
||
| own_prefix = _normalized(getattr(cls, "__prefix__", "")) | ||
|
|
||
| if namespace is not None: |
There was a problem hiding this comment.
🟠 Code Quality Violation
Found too many nested ifs within this condition (...read more)
Too many nested loops make the code hard to read and understand. Simplify your code by removing nesting levels and separate code in small units.
Comment on lines
+443
to
+445
| if own_prefix: | ||
| v._full_name = f"{own_prefix}_{v._full_name}" |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
Comment on lines
+431
to
+433
| if isinstance(v, EnvVariable): | ||
| v._full_name = f"{own_prefix}_{v._full_name}" |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
We extend the public API with an iterator that allows retrieving all the configuration items. This returns a mapping between attribute paths and environment variable instances. We also attach the full variable name to each EnvVariable instance, which is accessible via the ``full_name`` property.
P403n1x87
force-pushed
the
feat/items-iterator
branch
from
71d0edf
to
fd66b90
Compare
gnufede
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend the public API with an iterator that allows retrieving all the configuration items. This returns a mapping between attribute paths and environment variable instances. We also attach the full variable name to each EnvVariable instance, which is accessible via the
full_nameproperty.