Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit database_hostname with database_instance #18969

Merged
merged 27 commits into from
Nov 25, 2024

Conversation

sethsamuel
Copy link
Contributor

@sethsamuel sethsamuel commented Nov 1, 2024

What does this PR do?

Adds database_hostname (reflecting the actual host of the database for MySQL, Postgres, and SQLServer) to database instance metadata and server metrics.

Motivation

We currently submit reported_hostname as host and database_instance but this prevents users from grouping metrics by the underlying host. With database_hostname users will be able to do so even when using reported_hostname as a way of differentiating multiple database instances on a single host.

This is a purely additive change that does not yet tackle the full database instance/host problem.

See this ticket
for an example of a customer unable to correlate DBM metrics with infrastructure metrics.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (7b18212) to head (8a71460).
Report is 29 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 89.55% <100.00%> (+0.01%) ⬆️
postgres 93.27% <100.00%> (+3.95%) ⬆️
presto ?
slurm ?
solr ?
sqlserver 91.14% <100.00%> (+9.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sethsamuel sethsamuel marked this pull request as ready for review November 25, 2024 14:34
@sethsamuel sethsamuel requested review from a team as code owners November 25, 2024 14:34
@sethsamuel sethsamuel added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit 2ae8902 Nov 25, 2024
50 of 51 checks passed
@sethsamuel sethsamuel deleted the seth.samuel/DBMON-4728-database-hostname branch November 25, 2024 19:26
nubtron pushed a commit that referenced this pull request Nov 26, 2024
* database_hostname

* Lint

* Add database_hostname to tags

* _database_hostname

* Tests

* Changelog

* MySQL tests

* Tests

* Lint

* Fix

* Fix

* Fix

* Mysql

* Lint

* Fix

* Python

* Test

* Flaky

* Test

* Lint

* Revert

* Stub

* WIP

* Fix

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants