-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit database_hostname with database_instance #18969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
…728-database-hostname
steveny91
approved these changes
Nov 25, 2024
lu-zhengda
approved these changes
Nov 25, 2024
nubtron
pushed a commit
that referenced
this pull request
Nov 26, 2024
* database_hostname * Lint * Add database_hostname to tags * _database_hostname * Tests * Changelog * MySQL tests * Tests * Lint * Fix * Fix * Fix * Mysql * Lint * Fix * Python * Test * Flaky * Test * Lint * Revert * Stub * WIP * Fix * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
database_hostname
(reflecting the actual host of the database for MySQL, Postgres, and SQLServer) to database instance metadata and server metrics.Motivation
We currently submit
reported_hostname
ashost
anddatabase_instance
but this prevents users from grouping metrics by the underlying host. Withdatabase_hostname
users will be able to do so even when usingreported_hostname
as a way of differentiating multiple database instances on a single host.This is a purely additive change that does not yet tackle the full database instance/host problem.
See this ticket
for an example of a customer unable to correlate DBM metrics with infrastructure metrics.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged