Implement logic to catch externally built OpenSSL copies #19044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alopezz
force-pushed
the
alopez/control-openssl3-dependencies
branch
14 times, most recently
from
6338c48 to
13e86f8
Compare
alopezz
force-pushed
the
alopez/control-openssl3-dependencies
branch
12 times, most recently
from
8326f68 to
0372abf
Compare
alopezz
force-pushed
the
alopez/control-openssl3-dependencies
branch
13 times, most recently
from
52c0c5b to
5680648
Compare
alopezz
force-pushed
the
alopez/control-openssl3-dependencies
branch
from
5680648 to
48b2881
Compare
HadhemiDD
approved these changes
Dec 10, 2024
alopezz
force-pushed
the
alopez/control-openssl3-dependencies
branch
from
48b2881 to
72bd534
Compare
FlorentClarret
approved these changes
Dec 16, 2024
| with ZipFile(wheel) as zf: | ||
| names = zf.namelist() | ||
|
|
||
| return [name for name in names for pat in patterns if fnmatch(name, pat)] |
There was a problem hiding this comment.
Very nit because we do not care about performance here - you could yield each element instead of building a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
macOS is currently left out because that rises questions about psycopg2-binary, which would need to be addressed. Since this is already useful without that, that is left for future work (that may require discussion among a few teams to fully resolve).
Motivation
BARX-669
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged