-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBMON-4720: Make all sql server database metrics configurable #19111
Conversation
The |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
…s-core into allen.zhou-DBMON4720
The |
Co-authored-by: Zhengda Lu <zhengda.lu@datadoghq.com>
What does this PR do?
Motivation
Allowing database metrics collection to be individually configurable allows support to identify and triage performance issues related to metric collection. The new structure also is more extensible in the future, it is now easy to add related metric collection configurations.
Prevent passing instance_config unnecessarily down to SqlserverDatabaseMetricsBase objects, when it can all be handled in the initial configuration of SQLServerConfig.
OLD CONFIGURATION STRUCTURE
include_xyz_metric : True
include_foo_metric: False
include_xyz_metric_tempdb: False
include_xyz_metric_interval: 300
etc...
NEW CONFIGURATION STRUCTURE
database_metrics
xyz_metric
enabled: True
interval: 300
enabled_tempdb: False
foo_metric
enabled: False
etc...
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged