Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use start_date instead of execution_date for ongoing duration metrics #19278

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Dec 17, 2024

What does this PR do?

This PR uses the start_date instead of execution_date for ongoing duration metrics

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (826f684) to head (2bd371e).
Report is 15 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
airflow 93.03% <100.00%> (+0.39%) ⬆️
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale marked this pull request as ready for review December 18, 2024 02:24
@Kyle-Neale Kyle-Neale requested review from a team as code owners December 18, 2024 02:24
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just suggestions about the tests, implementation lgtm!

airflow/tests/test_unit.py Outdated Show resolved Hide resolved
airflow/tests/test_unit.py Outdated Show resolved Hide resolved
iliakur
iliakur previously approved these changes Dec 18, 2024
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker, but I think we can get rid of an if-clause in the test_config_collect_ongoing_duration implementation.

airflow/tests/test_unit.py Outdated Show resolved Hide resolved
@Kyle-Neale Kyle-Neale added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit 79783c0 Dec 18, 2024
46 of 48 checks passed
@Kyle-Neale Kyle-Neale deleted the kyle.neale/airflow-fixes branch December 18, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants