-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datadog.cluster_agent.leader_election.is_leader
#19308
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
7a42a1d
to
fc74e60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment to suggest another approach to have a "is leader" metric easier to use.
Also it would be nice to add the metric in the OOTB Dashboard too.
@@ -68,6 +68,7 @@ | |||
'kubernetes_apiserver_kube_events': 'kubernetes_apiserver.kube_events', | |||
'language_detection_dca_handler_processed_requests': 'language_detection_dca_handler.processed_requests', | |||
'language_detection_patcher_patches': 'language_detection_patcher.patches', | |||
'leader_election_is_leader': 'leader_election.is_leader', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this metric wasn't designed to be exposed directly.
Instead it was added to be use as "label join", see:
integrations-core/datadog_cluster_agent/datadog_checks/datadog_cluster_agent/check.py
Lines 100 to 105 in c2c5bcd
'label_joins': { | |
'leader_election_is_leader': { | |
'labels_to_match': ['*'], | |
'labels_to_get': ['is_leader'], | |
} | |
}, |
IMO, if we want to make a metric that exposes the leader status we should use the metric value (1
if leader, 0
if follower) instead of the using a label.
Maybe it can be done in this check thanks to a metric transformer function that will convert the is_leader
label's value to a metric value.
you can find some transformer example in other openmetrics base check like
Line 231 in 642b2f9
def workqueue_transformer(self, metric, scraper_config): |
What does this PR do?
Datadog Cluster Agent exposes
leader_election_is_leader
.https://github.com/DataDog/datadog-agent/blob/c7f4f4e228f546dfb60fdceb6cb6ae92a14bca88/pkg/util/kubernetes/apiserver/leaderelection/metrics/metrics.go#L24-L32
Motivation
This metric is useful for troubleshooting the issue regarding leader election.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged