handle case insensitive db name in schema collection #19384
Merged
+79
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| db_name = db_name_lower | ||
| else: | ||
| self._log.debug( | ||
| "Skipping db {} as it is not in the databases list {} and collation is case sensitive".format( |
There was a problem hiding this comment.
small nit:
should be "Skipping db {} as it is not in the databases list {} OR collation is case sensitive"
azhou-datadog
previously approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a
KeyErrorbug in the SQL Server schema collection process. The issue occurred when the database name insys.databaseswas uppercase in a case-insensitive collation, such asSQL_Latin1_General_CP1_CI_AS.Motivation
https://datadoghq.atlassian.net/browse/DBMON-4901
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged