Skip to content

Remove deprovisioning metrics from OOB Karpenter Dashboard #21410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 30, 2025
Merged

Remove deprovisioning metrics from OOB Karpenter Dashboard #21410

merged 6 commits into from
Sep 30, 2025

Conversation

ddog-nasirthomas
Copy link
Contributor

What does this PR do?

Removes deprovisioning metrics from the Karpenter integration

Motivation

The current OOB dashboard for Karpenter still includes several deprovisioning metrics that were deprecated in the latest major upgrade of Karpenter. These metrics were last available in v0.32 and are no longer present in versions 1.0 and later. Details on the deprecation can be found here: https://karpenter.sh/v0.32/upgrading/v1beta1-migration/#metrics

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@ddog-nasirthomas ddog-nasirthomas requested review from a team as code owners September 22, 2025 14:19
janine-c
janine-c previously approved these changes Sep 22, 2025
View reviewed changes
steveny91
steveny91 reviewed Sep 22, 2025
View reviewed changes
karpenter/metadata.csv
karpenter.controller.runtime.reconcile_errors.count,count,,error,,The count of reconciliation errors per controller,0,karpenter,,,
karpenter.controller.runtime.reconcile_panics.count,count,,,,Total number of reconciliation panics per controller,0,karpenter,,,
karpenter.controller.runtime.terminal.reconcile.errors.count,count,,,,Total number of terminal reconciliation errors per controller,0,karpenter,,,
karpenter.deprovisioning.actions_performed.count,count,,execution,,The count of deprovisioning actions performed. Labeled by deprovisioner,0,karpenter,,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should get rid of these. It might be better to just list them as deprecated and the version they were deprecated in.

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed janine-c’s stale review September 22, 2025 19:35

Review from janine-c is dismissed. Related teams and files:

  • documentation
    • karpenter/metadata.csv
@codecov Codecov
Copy link

codecov bot commented Sep 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.00%. Comparing base (1b7cdc4) to head (bc2dfb6).
⚠️ Report is 52 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

steveny91
steveny91 reviewed Sep 24, 2025
View reviewed changes
@ddog-nasirthomas ddog-nasirthomas force-pushed the nasir.thomas/depreciate-deprovisioning-metrics branch 2 times, most recently from 8d0bc6a to 466e519 Compare September 24, 2025 17:41
@ddog-nasirthomas ddog-nasirthomas force-pushed the nasir.thomas/depreciate-deprovisioning-metrics branch from 2e86a64 to 466e519 Compare September 29, 2025 16:16
@github-actions GitHub Actions
Copy link

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@ddog-nasirthomas
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 30, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-09-30 13:27:45 UTC ℹ️ Start processing command /merge

2025-09-30 13:27:52 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-30 13:34:16 UTC ⚠️ MergeQueue: This merge request was unqueued

nasir.thomas@datadoghq.com unqueued this merge request

@ddog-nasirthomas
Copy link
Contributor Author

/merge-c

@ddog-nasirthomas
Copy link
Contributor Author

/remove

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 30, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-09-30 13:34:09 UTC ℹ️ Start processing command /remove

2025-09-30 13:34:13 UTC ℹ️ Devflow: /remove

@sarah-witt sarah-witt added this pull request to the merge queue Sep 30, 2025
Merged via the queue into master with commit a1b8a35 Sep 30, 2025
55 of 57 checks passed
@sarah-witt sarah-witt deleted the nasir.thomas/depreciate-deprovisioning-metrics branch September 30, 2025 14:01
github-actions bot pushed a commit to jdheyburn/integrations-core that referenced this pull request Sep 30, 2025
@jdheyburn
Remove deprovisioning metrics from OOB Karpenter Dashboard (DataDog#2…
0595b87 
…1410)

* Remove deprovisioning metrics from OOB Karpenter Dashboard

* Remove deprovisioning metrics from OOB Karpenter Dashboard

* Mark deprovisioning metrics as deprecated in v1+

* Undoing changes to fixtures and test

* Reverting changes to metrics.py

* Removing changelog a1b8a35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

@janine-c janine-c janine-c left review comments

@steveny91 steveny91 Awaiting requested review from steveny91

Assignees

No one assigned

Labels

agent/approved docs/review-requested documentation ecosystems/review-requested integration/karpenter mergequeue-status: removed product/review-requested team/agent-integrations team/documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddog-nasirthomas @steveny91 @sarah-witt @janine-c