Remove release workflow (#1089)

* Remove release workflow We consider lading's container to be the only supported release artifact at this time. If a use-case for binaries or the crates.io artifacts appear in the future we'll be glad to re-introduce them. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com> * changelog Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com> * PR review * re-introduce Create Github Release * adjust README to point to container release Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com> --------- Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
DataDog · Nov 4, 2024 · 319e9be · 319e9be
1 parent a7fed93
commit 319e9be
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 84 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -19,85 +19,3 @@ jobs:
         with:
           changelog: CHANGELOG.md
           token: ${{ secrets.GITHUB_TOKEN }}
-
-  upload-binaries:
-    strategy:
-      matrix:
-        include:
-          - target: aarch64-unknown-linux-gnu
-            os: ubuntu-latest
-
-          - target: x86_64-unknown-linux-gnu
-            os: ubuntu-latest
-
-          - target: x86_64-unknown-linux-musl
-            os: ubuntu-latest
-
-          - target: aarch64-unknown-linux-musl
-            os: ubuntu-latest
-
-          - target: aarch64-apple-darwin
-            os: macos-latest
-
-          - target: x86_64-apple-darwin
-            os: macos-latest
-
-      # Try to complete every job in the matrix, even if one fails.
-      fail-fast: false
-    runs-on: ${{ matrix.os }}
-
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - uses: taiki-e/install-action@3e1dd227d968fb9fa43ff604bd9b0ccd1b714919 # v2.44.40
-        with:
-          tool: cross
-
-      # This installs protobuf on the host (runner)
-      # This is not needed for cross-compiled targets, however there is no
-      # way to check the architecture of the current runner, so this just always
-      # runs.
-      - name: Install Protobuf
-        uses: ./.github/actions/install-protobuf
-
-      # Run the build & upload artifacts
-      - name: Build and upload lading binaries
-        uses: taiki-e/upload-rust-binary-action@3a8b5e35eb5fea810221264dfde09e920c1d5310 # v1.22.1
-
-        with:
-          bin: lading
-          no_default_features: true
-          target: ${{ matrix.target }}
-          checksum: sha256
-          token: ${{ secrets.GITHUB_TOKEN }}
-
-      # Auth for the S3 upload
-      - name: Configure AWS Credentials
-        uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2
-        with:
-          aws-access-key-id: ${{ secrets.LADING_RELEASE_BOT_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.LADING_RELEASE_BOT_SECRET_ACCESS_KEY }}
-          aws-region: us-west-2
-
-      # Copy from cargo target directory to S3 release bucket
-      - name: Upload binary to S3
-        run: |
-          aws s3 cp target/${{ matrix.target }}/release/lading s3://lading-releases/${{  github.ref_name }}/${{ matrix.target }}/lading
-
-  crates-io-publish:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-
-      - name: Install protobuf
-        run: sudo apt-get update && sudo apt-get install -y protobuf-compiler
-
-      - name: Publish to crates.io
-        run: |
-          cargo publish \
-            --token ${{ secrets.CARGO_REGISTRY_TOKEN }} \
-            --locked \
-            --package lading-capture
-          cargo publish \
-            --token ${{ secrets.CARGO_REGISTRY_TOKEN }} \
-            --locked \
-            --package lading
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Unreleased
 ### Fixed
 - Target pid watcher will not report 0 for containers.
+### Removed
+- Container is now the only supported release artifact, removing crates.io
+  publish and binaries.
 
 ## [0.23.4]
 ### Added

diff --git a/README.md b/README.md
@@ -122,8 +122,8 @@ To give `lading` extra permissions needed, `setcap` can be used to grant the bin
 
 ## How to get a build (besides building from source)
 
-### Binary Releases
-https://github.com/DataDog/lading/releases
+### Container Releases
+https://github.com/DataDog/lading/pkgs/container/lading
 
 ### Docker