Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parametric] Enable the W3C Phase 3 test for cpp #2784

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zacharycmontoya
Copy link
Contributor

Motivation

Ensures that our handling of the W3C Trace Context headers is complete and provides the best distributed tracing experience.

Changes

Enables the following test cases for cpp:

  • tests/parametric/test_headers_tracecontext.py::Test_Headers_Tracecontext::test_tracestate_w3c_p_extract_datadog_w3c

Depends on functionality introduced in DataDog/dd-trace-cpp#142

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@zacharycmontoya
Copy link
Contributor Author

Note: This is expected to fail until the related PR gets merged. Until then, I will keep this in draft

@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/w3c-phase3-cpp branch from 84370f6 to 69d3194 Compare September 23, 2024 23:21
@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/w3c-phase3-cpp branch from 1b567e0 to 068d3af Compare December 4, 2024 21:19
@zacharycmontoya zacharycmontoya marked this pull request as ready for review December 4, 2024 21:36
@zacharycmontoya zacharycmontoya requested review from mabdinur and a team as code owners December 4, 2024 21:36
@zacharycmontoya
Copy link
Contributor Author

Note: The cpp parametric tests are passing, which indicates this update is successful

@mabdinur
Copy link
Contributor

mabdinur commented Dec 5, 2024

This PR is blocked by: DataDog/dd-trace-cpp#170.

The cpp parametric app does not support the new trace/span/extract_headers endpoint. Currently all parametric tests that generate spans from http headers are skipped.

cc: @dmehala

@zacharycmontoya zacharycmontoya marked this pull request as draft December 6, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants