Test for zombie processes in crashtracking #3364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingosse
changed the title
robertomonteromiguel
requested changes
Nov 14, 2024
There was a problem hiding this comment.
- This PR is very large, I would have preferred to have divided it into several parts, for example, by language.
- There are lint failures
- There are failures on gitlab
- I propose not to create a new scenario, but to use the existing scenario “INSTALLER_AUTO_INJECTION”. This new test case will be executed together with other tests. The condition is after breaking the application, restore it.
tests/auto_inject/utils.py
Outdated
| vm_port = virtual_machine.deffault_open_port | ||
| warmup_weblog(f"http://{vm_ip}:{vm_port}/") | ||
|
|
||
| def get_child_pids(self, virtual_machine) -> str: |
There was a problem hiding this comment.
why not add this methods to the weblog interface?
| @@ -651,6 +651,14 @@ def all_endtoend_scenarios(test_object): | |||
| github_workflow="libinjection", | |||
| ) | |||
|
|
|||
| container_auto_injection_install_script_crashtracking = InstallerAutoInjectionScenario( | |||
There was a problem hiding this comment.
I advocate for using the existing scenario "INSTALLER_AUTO_INJECTION" . And after break the app, restore the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://datadoghq.atlassian.net/browse/APMLP-289 and https://datadoghq.atlassian.net/browse/APMLP-290
Changes
Adds an injection test validating that crashtracking:
To look for child processes, the weblog exposes a
/child_pidsendpoint that browses the/procfolder to find the parent processes. It doesn't rely onpsbecause it's not available in some containers.To look for zombie processes, the weblog exposes a
/fork_and_crashthat spawns a copy of the process (using fork whenever possible, or just manually starting a process on Java and .NET) then have it crash. We need a child process for this because if we crash the main process then the container will be teared down and we won't be able to observe any zombie.The tests currently fail on Ruby, I think it runs without the crashtracking fix.
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present