Skip to content

Conversation

jpbempel
Copy link
Member

Motivation

testing new feature Capture Expressions for method and line log probe

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

method and line log probe
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/debugger/probes/probe_capture_expressions_complex.json            @DataDog/debugger @DataDog/system-tests-core
tests/debugger/probes/probe_capture_expressions_line.json               @DataDog/debugger @DataDog/system-tests-core
tests/debugger/probes/probe_capture_expressions_method.json             @DataDog/debugger @DataDog/system-tests-core
tests/debugger/test_debugger_capture_expressions.py                     @DataDog/debugger @DataDog/system-tests-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant