Skip to content

Conversation

nccatoni
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Copy link
Contributor

github-actions bot commented Oct 17, 2025

CODEOWNERS have been resolved as:

.github/chainguard/self.changelog.sts.yaml                              @DataDog/system-tests-core
.github/workflows/changelog.yml                                         @DataDog/system-tests-core
utils/scripts/update_change_log.sh                                      @DataDog/system-tests-core
utils/scripts/get-change-log.py                                         @DataDog/system-tests-core
utils/scripts/libraries_and_scenarios_rules.yml                         @DataDog/system-tests-core

@nccatoni nccatoni force-pushed the nccatoni/auto-changelog branch from c6b924d to 1dc324d Compare October 17, 2025 09:25
@nccatoni nccatoni marked this pull request as ready for review October 17, 2025 15:04
@nccatoni nccatoni requested a review from a team as a code owner October 17, 2025 15:04
@nccatoni nccatoni requested a review from cbeauchesne October 17, 2025 15:22
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a dedicated action to install the env :

      - name: Install runner
        uses: ./.github/actions/install_runner

python-version: "3.12"

- name: Install dependencies
shell: bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong, the default is bash

pull-requests: write
id-token: write
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this inside the step that needs it, to prevent exposing a token to all steps

exit 0
fi

echo "branch_exists=false" >> "$GITHUB_OUTPUT"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow here to overwrite existing branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants