Add variable to determine sidecar container position in container list#47
Draft
Kashuab wants to merge 3 commits intoDataDog:mainfrom
Draft
Add variable to determine sidecar container position in container list#47Kashuab wants to merge 3 commits intoDataDog:mainfrom
Kashuab wants to merge 3 commits intoDataDog:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a variable that allows users to determine if the container is prepended or appended. Appending the sidecar container instead of prepending helps for migration cases.
Motivation
Upon trying to deploy with this module,
terraform applywas failing with the following error:[ { "@type": "type.googleapis.com/google.rpc.BadRequest", "fieldViolations": [ { "description": "Revision template should contain exactly one container with an exposed port.", "field": "template.containers" } ] } ]My hypothesis is that since the default behavior is to prepend the sidecar container into the service, Google was trying to update the existing main service container to be the sidecar (retaining the
portsfor some reason) while simultaneously creating a new app container to serve traffic.Using an
appendstrategy solved the error in our case, because it instead only creates a new container without ports by default.Describe how you validated your changes
Ran
terraform applyusing the latest commit on the fork, anddatadog_sidecar_position = "append"on both modules definitions and the issue was resolved.Additional Notes