WIP: MA-6790 Setup Monitor Assets Schema #3334
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneyuandd
approved these changes
Nov 24, 2025
Contributor
shaneyuandd
left a comment
shaneyuandd
left a comment
There was a problem hiding this comment.
PR still in draft. Overall LGTM, left a couple questions.
| } | ||
|
|
||
| // Assets | ||
| if assets := r.buildAssetsStruct(ctx, state.MonitorAssets); len(assets) > 0 { |
Contributor
There was a problem hiding this comment.
Question: On API level, if client makes an Update Monitor request with assets not defined, does it removed all assets on the monitor or preserving existing assets?
| categoryStr, _ := aMap["category"].(string) | ||
| nameStr, _ := aMap["name"].(string) | ||
| urlStr, _ := aMap["url"].(string) | ||
| if categoryStr == "" || nameStr == "" || urlStr == "" { |
Contributor
There was a problem hiding this comment.
Curious if this is a possible scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Support for Saving Monitor Assets alongside monitors to support our new Runbooks integration, includes new test cases that handle saving a monitor with multiple runbooks.
PR will be in draft until the api spec changes get merged: https://github.com/DataDog/datadog-api-spec/pull/4551