Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.

Conversation

@Kr0nox
Copy link
Contributor

@Kr0nox Kr0nox commented Feb 11, 2025

Adds option for

  • layouting
  • hiding edge labels
  • simplyfing node names

Addresses parts of DataFlowAnalysis/DataFlowAnalysis#226

@Kr0nox Kr0nox marked this pull request as ready for review March 4, 2025 06:50
@Kr0nox Kr0nox added this to the 4.1.0 milestone Mar 4, 2025
@sebinside
Copy link
Member

sebinside commented Mar 4, 2025

Discussed improvements:

  • Remove node labels when choosing simplified names
  • Smaller minimal size/width for nodes
  • Add switch for read-only
    • Is deactivated if read-only is forced and cannot be changed
    • Can be toggled in edit / "normal" read-only mode
    • Is toggled automatically when applying hide edge labels or simplify node names

@sebinside sebinside self-requested a review March 4, 2025 12:12
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no obvious formatting issues (even in larger models), however, I found two bugs:

  • Activating one of the simplifying switches (no labels, simple names) shall activate read only, disabling read only shall disable both simplifying switches
  • If read only is activated, changing the formatting option has no effect

Looks beautiful though for the CWA :D

image

@Kr0nox
Copy link
Contributor Author

Kr0nox commented Mar 8, 2025

If read only is activated, changing the formatting option has no effect

It does change the formatting option in the tool-palette.
It not performing the layouting is the intended behavior, as formatting over the tool pallet was previously also not allowed through the pallet. This also makes it stay in line with the disalowance of moving nodes

@Kr0nox Kr0nox requested a review from sebinside March 8, 2025 16:38
@sebinside sebinside removed this from the 4.1.0 milestone Mar 11, 2025
@sebinside sebinside added this to the 4.0.0 milestone Mar 11, 2025
@sebinside
Copy link
Member

sebinside commented Mar 11, 2025

Comments from the meeting:

  • change enum to "mode"
  • two options: view and edit

This is sprechend.

@Kr0nox
Copy link
Contributor Author

Kr0nox commented Mar 12, 2025

Currently, disabling both simplifications options does disable read-only. Doing so would result in removing all annotations without the explicit actions of the user.
Thus I would suggest that readonly does not get disabled when both options get disabled

@Nicolas-Boltz Nicolas-Boltz requested review from Nicolas-Boltz and removed request for sebinside March 18, 2025 12:06
@Nicolas-Boltz Nicolas-Boltz dismissed sebinside’s stale review March 18, 2025 12:07

Weil du im Urlaub bist

Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicolas-Boltz Nicolas-Boltz merged commit ae622b5 into main Mar 18, 2025
1 check passed
@Nicolas-Boltz Nicolas-Boltz deleted the layout-options branch March 18, 2025 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants