-
Notifications
You must be signed in to change notification settings - Fork 1
Layout options #80
Layout options #80
Conversation
# Conflicts: # src/features/dfdElements/outputPortEditUi.ts
# Conflicts: # src/common/commandPalette.ts # src/features/constraintMenu/ConstraintMenu.ts # src/index.ts
|
Discussed improvements:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had no obvious formatting issues (even in larger models), however, I found two bugs:
- Activating one of the simplifying switches (no labels, simple names) shall activate read only, disabling read only shall disable both simplifying switches
- If read only is activated, changing the formatting option has no effect
Looks beautiful though for the CWA :D
It does change the formatting option in the tool-palette. |
|
Comments from the meeting:
This is sprechend. |
|
Currently, disabling both simplifications options does disable read-only. Doing so would result in removing all annotations without the explicit actions of the user. |
Nicolas-Boltz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Adds option for
Addresses parts of DataFlowAnalysis/DataFlowAnalysis#226