Skip to content

Fix geo_id type in read_geos...() function family#28

Open
allenbaron wants to merge 1 commit intomainfrom
fix/geos
Open

Fix geo_id type in read_geos...() function family#28
allenbaron wants to merge 1 commit intomainfrom
fix/geos

Conversation

@allenbaron
Copy link
Collaborator

This pull request ensures that joins on geo_id between geos datasets and other datasets work without an intermediate step to convert geo_id to character.

I'd like to merge this into main and then rebase the dev branch onto it, if no one is editing the dev branch. Otherwise, we should just merge this to both the main and dev branches.

Problem:
Type of 'geo_id' variable in geos datasets is not set;
it is sometimes of type integer and other times of type character.
In non-geos datasets (demographics, land area, etc.) 'geo_id' is
always of type character.

Fix:
Update all functions to coerce 'geo_id' to character when read.

Problem:
Type of 'geo_id' variable in geos datasets is not set;
it is sometimes of type integer and other times of type character.
In non-geos datasets (demographics, land area, etc.) 'geo_id' is
always of type character.

Fix:
Update all functions to coerce 'geo_id' to character when read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant