Fix geo_id type in read_geos...() function family#28
Open
allenbaron wants to merge 1 commit intomainfrom
Open
Conversation
Problem: Type of 'geo_id' variable in geos datasets is not set; it is sometimes of type integer and other times of type character. In non-geos datasets (demographics, land area, etc.) 'geo_id' is always of type character. Fix: Update all functions to coerce 'geo_id' to character when read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ensures that joins on
geo_idbetween geos datasets and other datasets work without an intermediate step to convertgeo_idto character.I'd like to merge this into main and then rebase the
devbranch onto it, if no one is editing thedevbranch. Otherwise, we should just merge this to both themainanddevbranches.Problem:
Type of 'geo_id' variable in geos datasets is not set;
it is sometimes of type integer and other times of type character.
In non-geos datasets (demographics, land area, etc.) 'geo_id' is
always of type character.
Fix:
Update all functions to coerce 'geo_id' to character when read.