Bug-97: tagObject Produces Orphaned Object
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se access modifier for sync methods to be protected to assist with testing
…verwrite a pid reference file and update junit test
… refs file already exists
…d add new junit test
…cid refs does to create pid refs file first
…as possible by wrapping relevant code blocks in try-catch statements
…fore proceeding with untagging, and add new junit tests
…d ensuring cid values are locked
…or confirming cid is locked
…etermineDeletion'
…PidFromCidRefsAndDetermineDeletion'
…dAndHandleCidDeletion'
taojing2002
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
unTagObjecthas been extracted fromtagObjectand is now triggered by the actual calling methodstoreHashStoreRefsFileswhich may run into an exception and necessitates the callunTagObject's synchronization has been removed, and in place of, new guard rails to ensure that the identifiers (pid, cid) are locked before proceedingIdentifierNotLockedException