-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature-11: storeMetadata Public API method #27
Conversation
… additional algorithm checksum value was omitted
…ithm is supplied but never calculated, and revise junit tests
…oreMetadataNamespace' to prepare for 'store_metadata()' implementation and update all junit test classes
…etrieveMetadata() and 'deleteMetadata'()'
…rithm and checksumAlgorithm
…ocs and junit tests
…dditional junit test for 'writeToTempFileAndGenerateChecksums'
… 'FileHashStoreProtectedTest' test class
… null character before writing body content 'metadata'
… overwrite files (previously always throws exception when target file exists)
…es multiple calls to store the same pid+formatId successfully
…LockedIds' (that is not failing locally)
…ata() to explicitly call .move() with entity as 'metadata'
…tExistsException' over 'FileAlreadyExistsException'
…in change from 'FileAlreadyExistsException' to 'pidObjectExistsException'
…ns being thrown in 'storeObject_objectLockedIds' test
…erify exception class encountered
…ads' for 'PidObjectAlreadyExistsException'
After reviewing the test logs from my last PR This To ensure confidence in the
I will review the tests once more with fresh eyes tomorrow morning, then merge this branch into develop if I don't see any further issues. |
Confirming that the change from |
…t tests for 'move()' and clean up code (fix typos, update javadocs, etc.)
Summary of Changes:
storeMetadata()
Public API method inFileHashStore
(plus other supporting protected methods)storeMetadata()
on the samehash(id+formatId)
only writes one file in total without any collisions (pid synchronization)storeObject
wherechecksumAlgorithm
is supplied but never utilized inwriteToTmpFileAndGenerateChecksums