Feature-55: storeObject and Reference Files Refactor
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s as the permanent address and update tests
…ce and update FileHashStore with placeholder methods
…for 'tagObject' method
…ise/add new junit tests
…xception class when pid refs file already exists
…test in new test class 'FileHashStoreReferencesTest'
…ns and add new junit tests
…HashStoreRefFiles' and add new junit tests
…idRefsFiles' and add new junit tests
…nced and improve logging and error statements
…, refactor 'getRealPath', update HashStore interface and update affected junit tests
… method for 'storeObject' to be called to with only an InputStream
…e by calling method 'storeObject'
… and add new exception class 'PidNotFoundInCidRefsFileException'
…e affected tests and classes, clean up code
…ol what size of files to skip
…ct from knbvm's metacatdb should be skipped or not
…TmpFileAndGenerateChecksums'
…and 'ReferencesTest'
…)' to convert a String object to an int object, now calls '.parseInt()'
… code and junit tests
…d new junit tests
…ndObject' process, and update junit tests
… and replace with return statement, and update junit tests
…, and 'verifyObject' to return a boolean value in 'FileHashStore'
…cksum algo and object size; and add/revise junit tests.'
…an object based on its cid and add new junit tests
…s to 'validateTmpobject'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature branch consists of the changes required for HashStore to integrate into Metacat's current workflow. Specifically, the ability to store an object in the absence of an identifier.
Summary of Changes:
storeObjecthas been refactored to allow for storing data only@taojing2002 When you are back from your break and settled in, can you please help review this pull request? After receiving/incorporating your feedback, we can then merge this into develop and then main and officially release HashStore-java 1.0.0