Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimization flag #850

Closed
wants to merge 1 commit into from
Closed

Fix optimization flag #850

wants to merge 1 commit into from

Conversation

sbvoxel
Copy link
Contributor

@sbvoxel sbvoxel commented Apr 30, 2024

Found by ChatGPT 4

Found by ChatGPT 4
@sbvoxel
Copy link
Contributor Author

sbvoxel commented Apr 30, 2024

I'm not making any judgement call on whether or not this flag is a good idea, but this was clearly the original intent. Alternatively the flag could be removed.

@Alanscut
Copy link
Collaborator

Alanscut commented May 6, 2024

I'm not making any judgement call on whether or not this flag is a good idea, but this was clearly the original intent

+1

The -01 looks like a typo. -O1 is the default optimization level of GCC, while clang has a default value of -O0.
This will be enabled when sanitizer was turned on. I'm not that familiar with sanitizer. Does the -O1 flag affect sanitizer?

@Alanscut
Copy link
Collaborator

Alanscut commented May 9, 2024

The current misused flag -01 looks like a typo of -O1 and will not work. And I do not think the flag -O1 can do any help with sanitizer.

I prefer removing this flag to be more consistent with current behavior.

Alanscut added a commit to Alanscut/cJSON that referenced this pull request May 9, 2024
Alanscut added a commit that referenced this pull request May 9, 2024
@Alanscut Alanscut closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants