fix: remove -O3 flag from Makevars.win and add p >= MAXDIM guard#11
Open
Davidvandijcke wants to merge 1 commit intomainfrom
Open
fix: remove -O3 flag from Makevars.win and add p >= MAXDIM guard#11Davidvandijcke wants to merge 1 commit intomainfrom
Davidvandijcke wants to merge 1 commit intomainfrom
Conversation
- Remove PKG_FFLAGS = -O3 from src/Makevars.win (CRAN policy violation) - Add stop() in r3d() and r3d_bwselect() when p >= 10 to prevent silent all-zero Fortran results from MAXDIM limit Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PKG_FFLAGS = -O3fromsrc/Makevars.winto comply with CRAN policy (overriding toolchain optimization defaults)stop()inr3d()andr3d_bwselect()whenp >= 10to prevent silent all-zero Fortran results from theMAXDIMlimitTest plan
devtools::document()passesdevtools::check()passes with 0 errors, 0 warnings🤖 Generated with Claude Code