fix: review findings for montecarlo/04_stata_coverage.R#26
Open
Davidvandijcke wants to merge 3 commits intomainfrom
Open
fix: review findings for montecarlo/04_stata_coverage.R#26Davidvandijcke wants to merge 3 commits intomainfrom
Davidvandijcke wants to merge 3 commits intomainfrom
Conversation
…scope, saving CI)
S1: Fix double-dereference ``fuzzy'' / ``weights'' -> `fuzzy' / `weights'
S7: Read r(pilot_den) and r(h_den) into locals immediately after Mata call
before intervening commands can clear r() results
S8: Track Mata loading success via local mata_loaded instead of ambient _rc
S18: Remove redundant tempvar drops in r3d_bwselect.ado
S21: saving() now writes bootstrap CB bounds instead of pointwise normal CI
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- F1: move set.seed(99999) before the delta loop; cache y_below outside loop - F2: replace column-1-only NA check with full-row validity across all matrices - F3: add stopifnot(length(true_tau) == NQ) after true_tau assignment - F4: derive NQ <- length(Q_GRID) instead of hardcoding 9 independently - F5: use seq_len(N_SIMS) instead of 1:N_SIMS - F6: add dir.exists(stata_dir) guard before loop; stop on empty results - F7: track pval_valid mask separately; report n_pval_valid; use it for rejection rates Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fixes from code review pipeline.