Skip to content

[Refactor] 그룹 도메인에 검증 로직을 추가한다 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

vectorch9
Copy link
Contributor

🗒️ Summary

검증 추가

  • 최대 가입 그룹
  • 최대 그룹 인원 검증
  • 그룹 내 퀘스트 최대 개수

리팩토링

  • 그룹의 회원과 관련된 로직을 Groups에서 GroupUsers로 옮김

resolve: #113

💡 More

@vectorch9 vectorch9 self-assigned this Nov 17, 2023
Copy link

Test Results

225 tests  +5   225 ✔️ +5   4s ⏱️ ±0s
  39 suites ±0       0 💤 ±0 
  39 files   ±0       0 ±0 

Results for commit 58524b6. ± Comparison against base commit 52fb53d.

This pull request removes 3 and adds 8 tests. Note that renamed tests count towards both.
daybyquest.group.domain.GroupsTest ‑ 사용자를_추가할_때_관리자_역할이라면_MODERATOR_여부를_검증한다()
daybyquest.group.domain.GroupsTest ‑ 사용자를_추가할_때_회원_역할이라면_사용자ID_존재여부를_검증한다()
daybyquest.group.domain.GroupsTest ‑ 사용자를_추가할_땐_그룹ID의_존재여부와_이미_회원이_아닌지_검증한다()
daybyquest.group.domain.GroupUsersTest ‑ 사용자를_추가할_때_가입한_그룹이_10개_이상이면_예외를_던진다()
daybyquest.group.domain.GroupUsersTest ‑ 사용자를_추가할_때_관리자_역할이라면_MODERATOR_여부를_검증한다()
daybyquest.group.domain.GroupUsersTest ‑ 사용자를_추가할_때_그룹_인원이_100명_이상이면_예외를_던진다()
daybyquest.group.domain.GroupUsersTest ‑ 사용자를_추가할_때_그룹이_없다면_예외를_던진다()
daybyquest.group.domain.GroupUsersTest ‑ 사용자를_추가할_때_이미_가입한_그룹이라면_예외를_던진다()
daybyquest.group.domain.GroupUsersTest ‑ 사용자를_추가할_때_회원_역할이라면_사용자ID_존재여부를_검증한다()
daybyquest.group.domain.GroupUsersTest ‑ 사용자를_추가할_땐_그룹ID의_존재여부와_이미_회원이_아닌지_검증한다()
daybyquest.quest.domain.QuestsTest ‑ 그룹_내_퀘스트가_10개_이상이면_예외를_던진다()

@vectorch9 vectorch9 merged commit 9b89d92 into develop Nov 17, 2023
@vectorch9 vectorch9 deleted the refactor/group branch November 17, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

그룹 도메인 검증을 추가한다
1 participant