Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] 퀘스트, 참여 도메인과 쿼리 테스트를 작성한다 #85

Merged
merged 8 commits into from
Nov 4, 2023

Conversation

vectorch9
Copy link
Contributor

🗒️ Summary

테스트 작성

  • QuestParticipant의 도메인, 쿼리 테스트를 작성
  • 관련 Fixtures와 유틸 클래스 추가

리팩토링

  • Quest의 검증 로직을 수정하고 부족한 로직 추가
  • Pariticpant의 검증 로직을 수정하고 부족한 로직 추가
  • IncreaseLinkedCounterListener가 하나의 트랜잭션에서 수행되도록 수정함
    • 여러 트랜잭션에서 수행된다면 정합성이 깨질 가능성이 있다고 판단함
    • 서로 다른 DB로 분리되었다면 ? 어떻게 해야할까..

resolve: #62

💡 More

@vectorch9 vectorch9 added the test label Nov 4, 2023
@vectorch9 vectorch9 self-assigned this Nov 4, 2023
Copy link

github-actions bot commented Nov 4, 2023

Test Results

160 tests  +58   160 ✔️ +58   3s ⏱️ -2s
  29 suites +  7       0 💤 ±  0 
  29 files   +  7       0 ±  0 

Results for commit 5e612c8. ± Comparison against base commit ff47099.

@vectorch9 vectorch9 merged commit 0ec7be4 into develop Nov 4, 2023
3 checks passed
@vectorch9 vectorch9 deleted the test/quest branch November 4, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

퀘스트 테스트를 작성한다
1 participant