Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] 사진 도메인을 리팩토링하고 테스트를 작성한다 #89

Merged
merged 7 commits into from
Nov 4, 2023

Conversation

vectorch9
Copy link
Contributor

🗒️ Summary

리팩토링

  • Image의 패키지를 vo에서 domain으로 변경
  • ImageimageIdentifier가 중복된 의미를 갖고있으므로 identifier로 변경
  • Images 업로드 메서드가 이제 identifier를 통해 생성한 Image 인스턴스를 반환
  • Image 검증 로직 추가

resolve: #87

💡 More

Copy link

github-actions bot commented Nov 4, 2023

Test Results

172 tests  +4   172 ✔️ +4   5s ⏱️ -1s
  32 suites +1       0 💤 ±0 
  32 files   +1       0 ±0 

Results for commit 35c7d86. ± Comparison against base commit cbef9dc.

@vectorch9 vectorch9 merged commit 3f7f042 into develop Nov 4, 2023
3 checks passed
@vectorch9 vectorch9 deleted the refactor/image branch November 4, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

사진의 패키지를 domain으로 변경하고 테스트를 작성한다
1 participant