Skip to content

Conversation

iamh2o
Copy link
Contributor

@iamh2o iamh2o commented Sep 9, 2025

Summary

  • add new Snakemake rule for running facets-suite on tumor-normal pairs
  • wire rule into main workflow and configuration templates
  • register facets as a somatic SNV caller

Testing

  • pytest

https://chatgpt.com/codex/tasks/task_e_68bf7aeb89f48331849ef7e083db44cf

@Copilot Copilot AI review requested due to automatic review settings September 9, 2025 04:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates the facets-suite somatic variant caller into the Snakemake workflow by adding a new rule and wiring it into the existing pipeline configuration.

  • Adds a new Snakemake rule facets_suite to run the facets-suite variant caller on tumor-normal pairs
  • Registers facets as a somatic SNV caller in the global configuration
  • Provides resource configuration templates for both SLURM and local execution environments

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
workflow/rules/facets_suite.smk Implements the main facets-suite rule and target gathering rule
workflow/Snakefile Includes the new facets-suite rule file
config/global.yaml Registers facets as a somatic SNV caller
config/day_profiles/slurm/templates/rule_config.yaml Adds SLURM-specific resource configuration for facets
config/day_profiles/local/templates/rule_config.yaml Adds local execution resource configuration for facets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -0,0 +1,74 @@
import os
Copy link

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The os module is imported but never used in this file. This unused import should be removed to keep the code clean.

Suggested change
import os

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant