Skip to content

Conversation

iamh2o
Copy link
Contributor

@iamh2o iamh2o commented Sep 9, 2025

Summary

  • generate Strelka region.bed files with bgzip/tabix outside of the container
  • consume pre-indexed region beds in Strelka germline and somatic rules

Testing

  • snakemake --lint -s workflow/Snakefile (fails: command not found)

https://chatgpt.com/codex/tasks/task_e_68bfd3cce8448331824b59104268e5ca

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +44 to +45
vchr=$(echo {params.cpre}{params.schrm} | sed 's/~/\:/g' | sed 's/23\:/X\:/' | sed 's/24\:/Y\:/' | sed 's/25\:/{params.mito_code}\:/' )
vchr=${vchr%:}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P0] Escape braces in region bed shell commands

The new region‑bed rules use Bash parameter expansion (vchr=${vchr%:}) without escaping the braces for Snakemake’s .format call. When Snakemake renders the rule, it treats {vchr%:} as a placeholder and raises KeyError: 'vchr%', so neither the germline nor somatic Strelka jobs can run. The line should use doubled braces, e.g. vchr=${{vchr%:}}, and the same fix is needed in the somatic rule around the corresponding lines.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant