You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our GitHub CI is somehow not seeing the changes I made to python.rs when rebuilding the Python package, so it's failing its (new) pytest which expects the bound strings to be a list instead of a set and allows default parameter values in index_search. I have no idea why; I can pass all Python tests locally. @AgentElement, can you look at this when you get a chance?
pip looks for packages in a number of places: on PyPI (or the index given as --index-url, if not disabled via --no-index), in the local filesystem, and in any additional repositories specified via --find-links or --extra-index-url. There is no priority in the locations that are searched. Rather they are all checked, and the “best” match for the requirements (in terms of version number - see the specification for details) is selected.
Is it possible that somewhere amidst our new v0.5.0 release, our runner is pulling from PyPI instead of the local repository specified by --find-links dist in our actions spec?
UPDATE 2: Yup, this was the problem. I have added --no-index to the pip installation command for our own package so that it never confuses the live version on PyPI with the locally built version that should be tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingfeatureAn entirely new capability
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113 and resolves #114. Specifically, the Python version of
index_searchnow:bound_strsparameter.indexfunction, which can be overridden as needed.The documentation and Python tests are updated accordingly.