Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template #9

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Update template #9

merged 8 commits into from
Oct 30, 2023

Conversation

talmurshidi
Copy link
Member

Description

Checklists

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

colevandersWands
colevandersWands requested changes Oct 27, 2023
View reviewed changes
package.json Outdated
"lint:md": "markdownlint --ignore node_modules --config ./.markdownlint.jsonc ./ ",
"lint:css": "stylelint './**/*.css'",
"lint:md": "markdownlint --config ./.markdownlint.jsonc ./ ",
"lint:css": "stylelint \"./**/*.css\"",
"validate:html": "html-validate ./",
"accessibility": "achecker"
},
"author": "HYF Belgium",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to DeNepo, since the license changed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@talmurshidi talmurshidi self-assigned this Oct 28, 2023
@talmurshidi talmurshidi added the enhancement New feature or request label Oct 28, 2023
@colevandersWands colevandersWands merged commit b6eaea0 into DeNepo:main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colevandersWands colevandersWands colevandersWands approved these changes

Assignees

@talmurshidi talmurshidi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talmurshidi @colevandersWands @sammou00