DEPLOY - v1.0.2.2 by youyeon11 · Pull Request #34 · DearBelly/DearBelly-BE-FastAPI

youyeon11 · 2025-10-03T06:15:04Z

📌 작업 목적

[FEATURE] GPU 정보 수집을 위한 모니터링 대상 변경

gemini-code-assist · 2025-10-03T06:15:22Z

Summary of Changes

Hello @youyeon11, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant update to the project's monitoring stack, shifting from direct FastAPI application instrumentation to a more specialized GPU monitoring solution. The core changes involve removing the prometheus-fastapi-instrumentator library and its associated Prometheus scrape jobs, and in its place, integrating the NVIDIA DCGM Exporter for detailed GPU metric collection. This refactor is complemented by necessary Docker Compose network configurations to ensure seamless operation of the new monitoring components and updated Prometheus settings to correctly ingest the new GPU metrics.

Highlights

Monitoring Refactor: Removed prometheus-fastapi-instrumentator from the FastAPI application, streamlining the application's dependencies and reducing its direct responsibility for metrics exposure.
GPU Monitoring Integration: Introduced dcgm-exporter into the docker-compose.monitoring.yml to enable comprehensive GPU performance monitoring, including resource reservations and capabilities for NVIDIA GPUs.
Prometheus Configuration Update: Modified prometheus.yml to remove the old FastAPI-specific scrape jobs and added a new job to scrape metrics from the dcgm-exporter service, centralizing GPU metric collection.
Docker Network Alignment: Updated docker-compose.yml to ensure both app-blue and app-green services are connected to the mynetwork, facilitating inter-service communication and integration with the new monitoring components.
Minor Prompt Adjustment: A small change in deployment/generate_review.py to adjust the tone of the Korean prompt for the AI review generation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

이 PR은 애플리케이션 레벨의 Prometheus 모니터링을 제거하고, dcgm-exporter를 도입하여 GPU 메트릭 모니터링으로 전환하는 것을 목표로 하는 것으로 보입니다. 관련하여 docker-compose.yml, prometheus.yml, requirements.txt 파일들이 일관성 있게 수정되었습니다. 전반적인 변경 방향은 명확하지만, 몇 가지 개선점을 제안합니다. Docker 이미지에 latest 태그를 사용하는 부분과 requirements.txt에 불필요한 logging 패키지가 포함된 점은 잠재적인 문제를 야기할 수 있으므로 수정이 필요합니다. 또한, 설정 파일의 유연성과 표준 준수를 위해 몇 가지 수정을 제안했습니다. 자세한 내용은 각 파일의 주석을 확인해주세요.

gemini-code-assist · 2025-10-03T06:16:41Z

deployment/docker-compose.monitoring.yml

      - mynetwork

+  dcgm-exporter:
+      image: nvcr.io/nvidia/k8s/dcgm-exporter:latest


Docker 이미지에 latest 태그를 사용하는 것은 프로덕션 환경에서 위험할 수 있습니다. latest 태그는 언제든지 변경될 수 있어, 예기치 않은 버전이 배포되어 장애를 유발할 수 있습니다. 안정적인 배포를 위해 3.3.5-3.4.2-ubuntu22.04와 같이 구체적인 버전 태그를 사용해주세요.

image: nvcr.io/nvidia/k8s/dcgm-exporter:3.3.5-3.4.2-ubuntu22.04

gemini-code-assist · 2025-10-03T06:16:41Z

requirements.txt

-logging
-prometheus-client==0.19.0
-prometheus-fastapi-instrumentator==6.1.0
+logging


logging은 Python의 표준 내장 모듈이므로 requirements.txt에 명시할 필요가 없습니다. 오히려 PyPI에 등록된 logging이라는 이름의 다른 패키지가 설치되어 의도치 않은 동작을 유발할 수 있습니다. 이 줄을 제거해주세요.

gemini-code-assist · 2025-10-03T06:16:42Z

deployment/docker-compose.yml

+
+networks:
+  mynetwork:
+    driver: bridge


파일 끝에 새 줄(newline)이 없습니다. POSIX 호환성을 위해, 그리고 일부 텍스트 처리 도구와의 예기치 않은 문제를 방지하기 위해 파일 끝에 새 줄을 추가하는 것이 좋습니다.

gemini-code-assist · 2025-10-03T06:16:42Z

deployment/prometheus.yml

+      - targets: ['127.0.0.1:9090']
        labels:
          service: 'monitor-1'
  - job_name: 'node'
    static_configs:
-      - targets: ['${REMOTE_HOST}:9090']
-  - job_name: 'fastapi-actuator-blue'
-    metrics_path: '/actuator/prometheus'
-    scrape_interval: 1m
+      - targets: ['127.0.0.1:9090']


127.0.0.1:9090으로 타겟을 하드코딩하면 다른 환경에서 재사용하거나 구성을 변경할 때 유연성이 떨어집니다. 이전처럼 ${REMOTE_HOST}와 같은 환경 변수를 사용하거나, 이것이 의도된 변경이라면 왜 하드코딩이 필요한지에 대한 주석을 추가하는 것을 고려해 보세요.

gemini-code-assist · 2025-10-03T06:16:42Z

deployment/prometheus.yml

-      - targets: [ 'app-green:8001' ]
+      - targets: ['dcgm-exporter:9400']
+        labels:
+          exporter: 'dcgm'


파일 끝에 새 줄(newline)이 없습니다. POSIX 호환성을 위해, 그리고 일부 텍스트 처리 도구와의 예기치 않은 문제를 방지하기 위해 파일 끝에 새 줄을 추가하는 것이 좋습니다.

youyeon11 and others added 6 commits October 3, 2025 14:57

refactor: 프롬프트 일부 수정

d7f5533

del: 불필요한 라이브러리 삭제(actuator)

bc908c7

feat: dcgm-exporter 컨테이너 추가(GPU 메트릭 수집)

fddbd53

feat: prometheus 정보 수집 대상 dcgm-exporter로 변경

ec569c4

del: healthcheck 삭제

7739b20

Merge pull request #33 from DearBelly/feat/add-exporter-32

1f5f292

[FEATURE] GPU 정보 수집을 위한 모니터링 대상 변경

youyeon11 merged commit 1e76a39 into main Oct 3, 2025
1 check failed

gemini-code-assist bot reviewed Oct 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPLOY - v1.0.2.2#34

DEPLOY - v1.0.2.2#34
youyeon11 merged 6 commits intomainfrom
develop

youyeon11 commented Oct 3, 2025

Uh oh!

Uh oh!

gemini-code-assist bot commented Oct 3, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Uh oh!

gemini-code-assist bot Oct 3, 2025

Uh oh!

gemini-code-assist bot Oct 3, 2025

Uh oh!

gemini-code-assist bot Oct 3, 2025

Uh oh!

gemini-code-assist bot Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

youyeon11 commented Oct 3, 2025

📌 작업 목적

Uh oh!

Uh oh!

gemini-code-assist bot commented Oct 3, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant